Fix #80863: ZipArchive::extractTo() ignores references #6959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to cater to references, when traversing the files to extract. While we're at it, we add an empty default clause, which would have caught this issue. We also move the `zval_file` declaration into a narrower scope, which makes it easier to reason about the value modification.
nikic
reviewed
May 7, 2021
We can simplify by using `zend_hash_index_find_deref()`. We must not have an empty default clause, since the array is allowed to contain arbitrary values.
nikic
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to cater to references, when traversing the files to extract.
While we're at it, we add an empty default clause, which would have
caught this issue. We also move the
zval_filedeclaration into anarrower scope, which makes it easier to reason about the value
modification.