Add host for php_network_getaddresses getaddrinfo failed error message. #7181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jun 21, 2021
derickr
approved these changes
Jun 21, 2021
Ocramius
approved these changes
Jun 21, 2021
dunglas
approved these changes
Jun 21, 2021
greg0ire
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Thank you so much for working on this! It believe it will be of great help for complex situations where you connect to many things, as well as for simple situations where you want to be sure your configuration was picked up by the code that makes the connection.
patrickallaert
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://twitter.com/greg0ire/status/1407039981328216067 I was thinking we could change this error message to include the failed host.
The modified tests with the 100 char length hostname might be an indicator for why its not the greatest idea, but on average hostnames are probably much shorter.
Is there a reason why its not included in the message? Security does not seem to be a problem, as host would not contain anything security related and displaying errors is already a security problem.
I checked a bit back in the commit history, the message has been this way forever (got back to 2003).