Skip to content

Generally usable persistent objects #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

krakjoe
Copy link
Member

@krakjoe krakjoe commented Jul 22, 2021

As part of #7212 we have to invent the concept of persistent objects.

Here is another possible approach to persistent objects, I'm not sure if it's flexible enough to do enums yet, but it looks technically simpler and more generally usable.

/cc @bwoebi @nikic what do we think of this approach ? and if we like it, what have I missed ?

@krakjoe
Copy link
Member Author

krakjoe commented Jul 22, 2021

CI is going to fail, because of fixed object ids in a lot of tests ... I'm going to ignore that while we decide if this is any good ...

@krakjoe krakjoe marked this pull request as draft July 22, 2021 08:57
@kocsismate
Copy link
Member

Could we use these persistent objects for backing persistent connections instead of using persistent resources?

@krakjoe
Copy link
Member Author

krakjoe commented Jul 24, 2021

Could we use these persistent objects for backing persistent connections instead of using persistent resources?

A default persistent connection maybe, because you'd need to know how to construct the object at MINIT stage.

@krakjoe
Copy link
Member Author

krakjoe commented Jul 24, 2021

Since the main use case was enums, and this doesn't look suitable for that without jumping through many hoops, and since Nikita has a better proposal for that, I'm gonna close this.

I don't think it's a terrible approach, maybe we revisit in the future but for now I'm not going to put more time into it.

@krakjoe krakjoe closed this Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants