Add support for internal enums #7302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this more than the persistent object approach. |
iluuu1994
approved these changes
Jul 24, 2021
| ce->enum_backing_type = type; | ||
| if (type != IS_UNDEF) { | ||
| ce->backed_enum_table = pemalloc(sizeof(HashTable), 1); | ||
| zend_hash_init(ce->backed_enum_table, 0, NULL, ZVAL_PTR_DTOR, 1); |
There was a problem hiding this comment.
If these will be mostly generated by stubs it would make sense to pass the right number of cases here right away.
There was a problem hiding this comment.
I think mostly is the point here. I don't see any reason to make the API more cumbersome than necessary.
dstogov
reviewed
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for internal enums with the same basic approach as userland enums. Enum values are stored as CONSTANT_AST and objects created during constant updating at runtime. This means that we need to use mutable_data for internal enums.
This just adds basic support and APIs, it does not include the stubs integration from #7212.