Skip to content

Generate optimizer func info from stubs for ext/sodium #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

kocsismate
Copy link
Member

No description provided.

@nikic
Copy link
Member

nikic commented Aug 26, 2021

TBH I'd be inclined to just delete this func info entirely. We already get the most valuable part through arginfo, and optimizing refcount on cryptographic code seems more risky than useful.

@kocsismate
Copy link
Member Author

OK, then I'll simply delete the @refcount parts. If we want to keep the additional return type hints, then we should also add a mechanism for excluding a function from being added to the optimizer func info. Or is it ok if the affected functions are added to it with a refcount of N?

@kocsismate
Copy link
Member Author

@nikic Do you see any other function/extension in zend_func_info.c which shouldn't been added to zend_func_infos.h before I try to migrate them?

@kocsismate kocsismate merged commit 765aec8 into php:master Aug 26, 2021
@kocsismate kocsismate deleted the func-info4 branch August 26, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants