Skip to content

Make a few unuseful DOMEntity properties readonly #7406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Aug 26, 2021

@kocsismate kocsismate merged commit 25cbd08 into php:master Aug 26, 2021
@kocsismate kocsismate deleted the domentity-readonly branch August 26, 2021 08:37
@salathe
Copy link
Contributor

salathe commented Aug 26, 2021

Can you clarify why making these readonly makes sense, I think I'm missing some details? My understanding is (correct me if I'm wrong): In DOM level 3, these properties are not readonly. In more recent specs (i.e. DOM Living Standard) the Entity interface is removed.

Copy link
Contributor

@salathe salathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the associated comments, which currently state: readonly=no.

@kocsismate
Copy link
Member Author

Can you clarify why making these readonly makes sense, I think I'm missing some details? My understanding is (correct me if I'm wrong): In DOM level 3, these properties are not readonly. In more recent specs (i.e. DOM Living Standard) the Entity interface is removed.

Short discussion: cdf2f3e#commitcomment-55396321

@salathe
Copy link
Contributor

salathe commented Aug 26, 2021

@kocsismate Thanks for the reference to the comment that prompted this change. A link back to that would have been useful in this PR's description or the commit message.

(Aside: I find it impossible to keep track of these discussions/comments on GitHub. Urgh. 😞 )

@kocsismate
Copy link
Member Author

Thanks for the reference to the comment that prompted this change. A link back to that would have been useful in this PR's description or the commit message.

Yes, I should probably make the discussion more visible by adding a link in the description. I didn't do it partly because GitHub displays a reference to the thread just below the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants