-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Make a few unuseful DOMEntity properties readonly #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you clarify why making these readonly makes sense, I think I'm missing some details? My understanding is (correct me if I'm wrong): In DOM level 3, these properties are not readonly. In more recent specs (i.e. DOM Living Standard) the Entity interface is removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the associated comments, which currently state: readonly=no
.
Short discussion: cdf2f3e#commitcomment-55396321 |
@kocsismate Thanks for the reference to the comment that prompted this change. A link back to that would have been useful in this PR's description or the commit message. (Aside: I find it impossible to keep track of these discussions/comments on GitHub. Urgh. 😞 ) |
Yes, I should probably make the discussion more visible by adding a link in the description. I didn't do it partly because GitHub displays a reference to the thread just below the description. |
Discussion: cdf2f3e#commitcomment-55396321