Support compile_string passing parsing state #7462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the feature is reasonable, but I really don't like having a global flag control this. Can we make it a function argument instead? |
huanghantao
force-pushed
the
support-compile-string-skip-initial
branch
2 times, most recently
from
c931840 to
2867959
Compare
|
Maybe we should call the parameter skip_end_of_file (or begin_initial) instead of skip_initial? |
huanghantao
changed the title
|
I wonder whether it would make sense to accept the starting state (as unsigned to avoid include)? That way you could start at yycST_IN_SCRIPTING, yycINITIAL or yycSHEBANG. This leaks internal details a bit though. |
|
I think this is a good suggestion, and it will facilitate further extensions of this function. Maybe someone really needs to start in another state. |
huanghantao
force-pushed
the
support-compile-string-skip-initial
branch
from
f7556db to
8b26bb1
Compare
huanghantao
changed the title
|
Whether |
nikic
reviewed
Sep 8, 2021
huanghantao
force-pushed
the
support-compile-string-skip-initial
branch
from
d621ffc to
668fd57
Compare
nikic
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this revision is good.
I have a requirement to execute encrypted PHP code.
Currently, I read the encrypted code into memory, then decrypt it, and write the decrypted content to a temporary file. Then call compile_file to fetch op_array.
Perhaps we can fetch op_array directly from compile_string. But it will report the problem:
Parse error: syntax error, unexpected token "<", expecting end of fileSo, I need to remove T_OPEN_TAG myself. So I think it's fine if compile_string can skip T_OPEN_TAG.