Don't populate CE_CACHE during compilation #7542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for CE_CACHE slots to be populated during compilation (e.g. due to an early binding attempt). When opcache then persists the class, it clears the CE_CACHE slot for the class name as declared, but not for different spellings (that only differ in case). As such, a pointer to the old, non-persistent class entry may be retained. Fix this by not populating CE_CACHE if in_compilation is set.
dstogov
approved these changes
Oct 4, 2021
| @@ -1101,7 +1101,8 @@ ZEND_API zend_class_entry *zend_lookup_class_ex(zend_string *name, zend_string * | |||
| } | |||
| return NULL; | |||
| } | |||
| if (ZSTR_HAS_CE_CACHE(name)) { | |||
| /* Don't populate CE_CACHE during compilation. The class may be freed while persisting. */ | |||
| if (ZSTR_HAS_CE_CACHE(name) && !CG(in_compilation)) { | |||
There was a problem hiding this comment.
At least, we may set CE_CACHE for immutable classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for CE_CACHE slots to be populated during compilation
(e.g. due to an early binding attempt). When opcache then persists
the class, it clears the CE_CACHE slot for the class name as declared,
but not for different spellings (that only differ in case). As such,
a pointer to the old, non-persistent class entry may be retained.
Fix this by not populating CE_CACHE if in_compilation is set.