Remove duplicated SKIP checks to improve performance #7858
Conversation
|
Thanks for this! And also thanks for the improvements to gh7837.phpt. I'll do a review of this PR tomorrow. |
There was a problem hiding this comment.
I like the cleanup of the inclusions of the helpers here.
I'm not sure about the changes in indentation; this still looks somewhat inconsistent, and it might be more reasonable to agree on a CS for PHPTs, and to enforce that with some automated script (scripts/dev/tidy.php might be extended).
Other than that, this looks good to me. Thank you!
| @@ -4,13 +4,15 @@ mysqli_ssl_set() - test is a stub! | |||
| mysqli | |||
| --SKIPIF-- | |||
| <?php | |||
| require_once('skipifconnectfailure.inc'); | |||
| die("skip test is a stub!"); | |||
There was a problem hiding this comment.
Not sure what to do with this test. It is apparently "a stub" since its introduction to the code base 234 years ago.
The changes in the indentation are only where I was changing something else already. I decided not to change formatting of the whole file as that would be too disruptive. I only changed it in sections that I was modifying anyway. As there's no one standard at the moment, it doesn't make much difference. The indentation is already all over the place. I'm not sure if it makes sense to employ coding standard, but it's not the topic of this PR. |
I thought this would speed up some tests, but it doesn't seem to improve it that much. It improves formatting and will prevent confusion in future tests in terms of which file should be included.