Fix GH-8068: mysqli_fetch_object creates inaccessible properties #8189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching into objects, we need to create object style hash tables, i.e. where numeric column names are stored as string keys instead of integer keys. Instead of the slightly more efficient alternative to create the desired hash table in the first place, we go for the more readable implementation and convert the array style hash table using `zend_symtable_to_proptable()`.
kamil-tekiela
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Thanks for fixing this. This is a simple solution and it works.
The only other alternative I see would be to add to mysqlnd a way of fetching an object HashTable but that would require changing a lot of code and possibly even duplicating some. This is probably not worth it for the performance gain it would bring.
I have checked the performance and, in my tests, it seems to be up to 40% worse. It's not good but at the same time I doubt it will be noticeable in real-life scenarios. I think we can live with it.
Co-authored-by: Kamil Tekiela <[email protected]>
Co-authored-by: Kamil Tekiela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching into objects, we need to create object style hash tables,
i.e. where numeric column names are stored as string keys instead of
integer keys. Instead of the slightly more efficient alternative to
create the desired hash table in the first place, we go for the more
readable implementation and convert the array style hash table using
zend_symtable_to_proptable().