ext/standard/file: disable the read buffer in file_get_contents() #8547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes a lot of sense to me. (Btw. code style nit: IIRC we always use {} for ifs, at the very least when a new line is used.) |
The read buffer is useless here, it only hurts performance.
MaxKellermann
force-pushed
the
file_get_contents-unbuffered
branch
from
82651e6 to
809a639
Compare
Fixed. |
bwoebi
approved these changes
May 16, 2022
cmb69
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read buffer is useless here, it only hurts performance.
(This used to be part of #8032)