Minor refactoring of main/main.c and TSRM #8608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsey
reviewed
May 23, 2022
main/php_stdint.h
Outdated
| @@ -1,51 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Will this change affect any PECL extensions?
There was a problem hiding this comment.
It might, but it shouldn't and the change is straight forward to use the standard C99 uint8_t type instead. But I will split this change into it's own PR and edit UPGRADING.INTERNAL.
Girgias
force-pushed
the
main-tsrm-small-refactor
branch
from
67a74f8 to
31e3d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also amend related API usage.