Skip to content

[skip-ci] Drop libmysql build from nightly #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented May 31, 2022

Hopefully this is all the relevant files for the libmysql build which is pointless now that 276e49c has landed.

@Girgias Girgias requested a review from iluuu1994 May 31, 2022 08:19
@cmb69
Copy link
Member

cmb69 commented May 31, 2022

Don't we have nightlies for older branches? Would they still run the libmysql-client job?

@cmb69
Copy link
Member

cmb69 commented May 31, 2022

Minor issue: [skip-ci] is not recognized by all CI runners; [ci skip] seems to be more generally supported.

@Girgias
Copy link
Member Author

Girgias commented May 31, 2022

Don't we have nightlies for older branches? Would they still run the libmysql-client job?

They would, but I think it make sense for them to still run it as it possible to build with libmysql

@cmb69
Copy link
Member

cmb69 commented May 31, 2022

@Girgias, ah, fine then. :)

@Girgias Girgias merged commit ab67b52 into php:master May 31, 2022
@Girgias Girgias deleted the nightly-no-libmysql branch May 31, 2022 10:30
@nikic
Copy link
Member

nikic commented May 31, 2022

libmysqlclient is still supported for PDO MySQL. This should be reverted only mysqli disabled in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants