Skip to content

Declare ext/gmp constants in stubs #8704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2022
Merged

Declare ext/gmp constants in stubs #8704

merged 3 commits into from
Jun 6, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate force-pushed the const-gmp branch 2 times, most recently from d205d8a to 2234fd6 Compare June 4, 2022 09:45
@kocsismate kocsismate requested a review from cmb69 June 4, 2022 09:45
cmb69
cmb69 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall this looks good to me, but maybe we want to enclose the macro definition in parentheses.

kocsismate and others added 2 commits June 6, 2022 14:35
@kocsismate kocsismate merged commit deabd5a into php:master Jun 6, 2022
@kocsismate kocsismate deleted the const-gmp branch June 6, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: gmp Stubs Waiting on Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @cmb69 @adoy