Mark *_arginfo.h as linguist-generated
#8722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated `*_arginfo.h` usually cannot be usefully reviewed within a PR. Collapse them by default by adding the `linguist-generated` attribute to reduce the visual noise. see https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github see https://github.com/github/linguist/blob/master/docs/overrides.md#summary
iluuu1994
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Since GH-8295 there's no longer a risk that somebody could inject malicious code in generated files, so collapsing makes sense to me. There are other files we could add here, like the files generated from zend_vm_gen.php, Bison, etc. But those can be added separately. Thanks @TimWolla!
@TimWolla Btw, you can add [skip ci] to the commit message when making non-code changes to avoid triggering the CI needlessly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated
*_arginfo.husually cannot be usefully reviewed within a PR.Collapse them by default by adding the
linguist-generatedattribute to reducethe visual noise.
see https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github
see https://github.com/github/linguist/blob/master/docs/overrides.md#summary