Fix debug backtrace frameno #8761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frame may be skipped in some cases, and the trace may be truncated before exceeding the limit.
|
no test? |
Sorry, this is a problem I met a long time ago in the extension, it doesn't fire through existing PHP code, I need to test it in zend_test, I just opened the PR to see if it would affect existing tests first. |
|
Well, I took a little time to try it out and I found that I couldn't construct such a test quickly, and I would be very grateful if someone could help me to do that, or allow me to try it later. |
|
Looking at 450f2ff it seems this only happens with phar files. Creating a test is probably not worth it, the fix looks and correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frame may be skipped in some cases, and the trace may be truncated before exceeding the limit.