check_parameters.php: Make the script's retval reflect errors #8790
Conversation
There was a problem hiding this comment.
Thank you for the PR! It certainly makes sense to set an appropriate status code on failure.
I'm not sure, though, whether this script is still that useful. After all, it doesn't seem to check the "new" fast parameter parsing API, and as of PHP 8.0.0, there are additional run-time checks regarding parameters in debug builds.
|
BTW, I just noticed that there is https://pecl.php.net/package/libvirt, but that never had a release. Maybe that'll change in the future. :) |
|
Yeah, I'm doing releases in the repository: https://gitlab.com/libvirt/libvirt-php/ |
I think it would make sense to (also) release via PECL. The necessary steps are listed on https://pecl.php.net/account-request.php. :) |
When the check_parameters.php script meets an error it prints it out but the exit value is not affected, it's still 0. This does not fly with projects that want to run this script as a part of their test suite. Therefore, make the script return 0 on success and 2 if any error was reported. Signed-off-by: Michal Privoznik <[email protected]>
|
Thanks again! |
When the check_parameters.php script meets an error it prints it
out but the exit value is not affected, it's still 0. This does
not fly with projects that want to run this script as a part of
their test suite.
Therefore, make the script return 0 on success and 1 if any error
was reported.
Signed-off-by: Michal Privoznik [email protected]