Skip to content

test coverage - iconv_strpos() internal encoding error #8816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

test coverage - iconv_strpos() internal encoding error #8816

wants to merge 5 commits into from

Conversation

juan-morales
Copy link
Contributor

Code coverage before the test:

image

Coverage after the test:

image

cmb69
cmb69 reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

cmb69
cmb69 reviewed Jun 21, 2022
View reviewed changes
@cmb69 cmb69 closed this in 804c708 Jun 21, 2022
@cmb69
Copy link
Member

cmb69 commented Jun 21, 2022

Thank you!

I've tweaked that test a bit (the %A must not be followed by a line break).

@juan-morales
Copy link
Contributor Author

Thanks @cmb69 . After vacations I Will keep writing tests to get More coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees
No one assigned
Labels
Extension: iconv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan-morales @cmb69