(p)ereallocarray introduction.
#8882
Conversation
| void *p; | ||
|
|
||
| size = zend_safe_address_guarded(nmemb, size, 0); | ||
| p = _erealloc(ptr, size ZEND_FILE_LINE_RELAY_CC ZEND_FILE_LINE_ORIG_RELAY_CC); |
There was a problem hiding this comment.
This is essentially exactly the same as safe_erealloc(ptr, nmemb, size, 0), no?
There was a problem hiding this comment.
But wasn't the point of reallocarray that in case of an overflow for m * n we don't touch the memory? I'm not completely sure what erealloc does with size 0.
There was a problem hiding this comment.
I just noticed, zend_safe_address_guarded triggers a zend_error_noreturn on overflow, so checking for 0 doesn't make sense. I wonder if this PR makes sense at all, if we can essentially just do safe_erealloc(ptr, nmemb, size, 0).
There was a problem hiding this comment.
You could still switch the few cases form erealloc to erealloc_safe 🙂
There was a problem hiding this comment.
sure I prefer a new fresh PR ;-)
devnexen
force-pushed
the
zend_ereallocarray_intro
branch
from
c0683b1 to
4e615e3
Compare
Sort of php#8871 follow-up but on the zend part.
devnexen
force-pushed
the
zend_ereallocarray_intro
branch
from
4e615e3 to
c426783
Compare
Sort of #8871 follow-up but on the zend part.