-
Notifications
You must be signed in to change notification settings - Fork 7.9k
LMDB Support for driver flags #8892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! However, I don't like to introduce DBA_LMDB_USE_SUB_DIR
; after all, this is a flags parameter, and as such a bitmask. Passing 0
should be sufficient, shouldn't it?
I think the reason why I added the constant is that the default would not be |
Yeah, I see your point. It is unfortunate, that we started with |
@kocsismate why am I getting an:
Error? I don't understand why it needs a CVALUE annotation as the value is defined in the stubs? |
But the value is |
The value is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (besides the two nits). Please add a note in NEWS and UPGRADING when merging.
Currently only LMDB with DBA_LMDB_USE_SUB_DIR/DBA_LMDB_NO_SUB_DIR are supported
This fixes #8856
I'm not exactly sure about the implementation for the driver flags as the way DBA is currently built the headers seem to be added somewhat magically.
These commit should also be kept separately.