add SensitiveParameter as known string and use it in arginfo #8991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
approved these changes
Jul 13, 2022
kocsismate
reviewed
Jul 18, 2022
| $code .= "\tzend_string *attribute_name_{$escapedAttributeName}_$nameSuffix = zend_string_init(\"" . addcslashes($this->class, "\\") . "\", sizeof(\"" . addcslashes($this->class, "\\") . "\") - 1, 1);\n"; | ||
| $code .= "\t" . ($this->args ? "zend_attribute *attribute_{$escapedAttributeName}_$nameSuffix = " : "") . "$invocation, attribute_name_{$escapedAttributeName}_$nameSuffix, " . count($this->args) . ");\n"; | ||
| $code .= "\tzend_string_release(attribute_name_{$escapedAttributeName}_$nameSuffix);\n"; | ||
| if (isset($knowns[$escapedAttributeName])) { |
There was a problem hiding this comment.
First, I tried to use a similar approach in case of known strings when I started to work on generating properties, but then Nikita asked me to simply ignore them and only use normal strings. My guess is that we don't really need to deal with known strings if the string in question is allocated as permanent (?).
That's why I think it would be more future-proof to just collect all the different attribute names and declare them at once. As this would be slightly more difficult to implement, let's go with your known-string based approach for beta 1.
kocsismate
approved these changes
Jul 18, 2022
|
Thanks for the reviews Merged in 55a88f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #8836
To avoid so much (148) init / release of the same string
notice, perhaps some others may be added later (AllowDynamicProperties only used 2 or Attribute only used in zend_test...)