Rerun of GC due to should_rerun_gc = 1 resets count variable, increasing buffer indefinitely #9265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The indentation is broken (use tabs), but otherwise this looks reasonable. |
|
Fixed, I'll try to provide a test case soon. |
olsavmic
force-pushed
the
mo-gc-destructor-do-not-reset-count
branch
from
52f652f to
5659a59
Compare
|
Does this also happen on PHP 8.0 or just 8.1? |
|
It's only affecting >=8.1 as the change was introduced in #5581 |
cmb69
approved these changes
Aug 8, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9266