zend introduce const GNUC attribute. #9326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sub optimisation where there is no pointers, nor particular memory layout, thread local/volatile ... involved. usage concealed for now into little pack helpers.
|
ARM seems to also have support for it: https://developer.arm.com/documentation/100067/0612/Compiler-specific-Function--Variable--and-Type-Attributes/--attribute----const---function-attribute |
|
is it clang or does it need particular preprocessor constants ? I tested both compilers locally. |
Seems like Clang supports according to: https://stackoverflow.com/a/49468797 asa I find the official docs of Clang a bit confusing: https://clang.llvm.org/docs/AttributeReference.html#const |
|
ah ok I see in the case of clang ZEND_GCC_VERSION (ie none 0) is also defined :) (I have tested locally clang too) |
iluuu1994
reviewed
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sub optimisation where there is no pointers, nor particular memory
layout, thread local/volatile ... involved.
usage concealed for now into little pack helpers.