Fix GH-9361: Segmentation fault on script exit #9379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a lot of memory may overflow some `int` calculations; to avoid that we make sure that the operands are promoted to `size_t`. This issue has been analyzed by @chschneider.
|
Maybe add a test like #9361 (comment) ? |
|
|
I guess you could usw the same script with less iterations and a smaller limit? |
That might not trigger the overflow. |
|
Yes, you need heap->cached_chunks_count to become big enough to trigger the overflow so reducing the memory limit and/or less iterations won't trigger it. |
iluuu1994
approved these changes
Aug 20, 2022
dstogov
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a lot of memory may overflow some
intcalculations; to avoidthat we make sure that the operands are promoted to
size_t.This issue has been analyzed by @chschneider.