Skip to content

Declare ext/standard constants in stubs - part 1 #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2022
Merged

Declare ext/standard constants in stubs - part 1 #9404

merged 2 commits into from
Aug 24, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

cmb69
cmb69 reviewed Aug 23, 2022
View reviewed changes
cmb69
cmb69 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thank you!

@kocsismate kocsismate merged commit bc4c012 into php:master Aug 24, 2022
@kocsismate kocsismate deleted the const-standard1 branch August 24, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi left review comments

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: spl Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @cmb69 @bwoebi