Skip to content

Add support for binary, and octal number prefixes for INI settings #9560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add support for binary, and octal number prefixes for INI settings #9560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
addfbf6
Add support for binary, and octal number prefixes for INI settings
Girgias Sep 16, 2022
f019895
Drop G modifier in test due to 32bit overflow
Girgias Sep 20, 2022
96d817c
Address some comments
Girgias Sep 24, 2022
227d8e6
Handle PHP_INT_MIN properly
Girgias Sep 27, 2022
e14035f
More error messages and improved
Girgias Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 Zend/tests/zend_ini_parse_quantity.phpt → ...sts/zend_ini/zend_ini_parse_quantity.phpt
View file
Open in desktop
File renamed without changes.
750 changes: 750 additions & 0 deletions Zend/tests/zend_ini/zend_ini_parse_quantity_binary_prefixes.phpt
View file
Open in desktop

Large diffs are not rendered by default.

44 changes: 44 additions & 0 deletions .../tests/zend_ini_parse_quantity_error.phpt → ...nd_ini/zend_ini_parse_quantity_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ $tests = [
'1X', # Unknown multiplier.
'1.0K', # Non integral digits.

'0X', # Valid prefix with no value
'0Z', # Invalid prefix
'0XK', # Valid prefix with no value and multiplier

'++',
'-+',
'+ 25',
'- 25',

# Null bytes
" 123\x00K",
"\x00 123K",
Expand Down Expand Up @@ -48,6 +57,41 @@ int(1)
Warning: Invalid quantity "1.0K", interpreting as "1K" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(1024)

# "0X"

Warning: Invalid quantity "0X": no digits after base prefix, interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# "0Z"

Warning: Invalid prefix "0Z", interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# "0XK"

Warning: Invalid quantity "0XK": no valid leading digits, interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# "++"

Warning: Invalid quantity "++": no valid leading digits, interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# "-+"

Warning: Invalid quantity "-+": no valid leading digits, interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# "+ 25"

Warning: Invalid quantity "+ 25": no valid leading digits, interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# "- 25"

Warning: Invalid quantity "- 25": no valid leading digits, interpreting as "0" for backwards compatibility in %s%ezend_ini_parse_quantity_error.php on line %d
int(0)

# " 123\000K"

Warning: Invalid quantity " 123\x00K", interpreting as " 123K" for backwards compatibility in %s on line %d
Expand Down
Loading