[skip ci] Amend coding style #9797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop irrelevant rule about // comments since PHP is C99 + GNU extensions Add rule about strlen() usage for constant string length calculation
Girgias
added
the
Category: Documentation
cmb69
reviewed
Oct 21, 2022
There was a problem hiding this comment.
Thank you!
I think I would have put this in the Code implementation section, probably just after item 5 (because that also talks about strlen(), although in a different context). It's okay for me to leave it where it is.
I would suggest to renumber to always use 1.. Markdown converters are supposed to handle this anyway, and this saves any renumbering.
iluuu1994
reviewed
Oct 21, 2022
Co-authored-by: Ilija Tovilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop irrelevant rule about // comments since PHP is C99 + GNU extensions
Add rule about strlen() usage for constant string length calculation