Fix GH-9932: Discards further characters for session name. #9940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As those are converted, it s better to make aware of the code caller of the naming inadequacy.
devnexen
force-pushed
the
session_name_discarded_chars_upd
branch
from
0b9aa2b to
3dafa5f
Compare
|
Isn't this also an issue in previous versions? In any case the change makes sense to me. |
cmb69
approved these changes
Nov 15, 2022
| @@ -93,6 +93,8 @@ zend_class_entry *php_session_update_timestamp_iface_entry; | |||
| return FAILURE; \ | |||
| } | |||
|
|
|||
| #define SESSION_FORBIDDEN_CHARS "=,;.[ \t\r\n\013\014" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As those are converted, it s better to make aware of the code caller of the naming inadequacy.