Use tagged version of php-sdk-binary-tools #5
Conversation
See <https://github.com/php/php-sdk-binary-tools?tab=readme-ov-file#internal-notes>. According to that documentation, for PHP 7.0 and 7.1, PHP SDK 2.1 would be required; however, we already used newer versions, and so far nobody had complained, apparently. So maybe the php-sdk-binary-tools README is not quite correct, or we would need to adapt the tag for those PHP versions. On the other hand, it is somewhat unlikely that these old versions are still in use, so we don't care too much about that.
|
Since php-sdk-2.3.0 had not yet been tagged, this is just a draft and must not be merged. |
|
FWIW: I am still using https://github.com/OSTC/php-sdk-binary-tools.git with my own dependencies and some adjustments for newer PHP-versions. Works fine for PHP 5.3 up until 8.3. PHP 8.4 with VS16 works fine as well, but 8.4 alpha 1 with VS17 stumbled over https://github.com/php/php-src/blob/ffab987fb1e0cfe2e2c361dcf88644fc9048057d/win32/build/confutils.js#L2946 |
Hasn't this been fixed with php/php-src@ffab987? |
I will try that with alpha 2. |
Works! Building with a lot of extensions: https://phpdev.toolsforresearch.com/php-8.4.0alpha2-nts-Win32-vs17-x64.htm |
See https://github.com/php/php-sdk-binary-tools?tab=readme-ov-file#internal-notes.
According to that documentation, for PHP 7.0 and 7.1, PHP SDK 2.1 would be required; however, we already used newer versions, and so far nobody had complained, apparently. So maybe the php-sdk-binary-tools README is not quite correct, or we would need to adapt the tag for those PHP versions. On the other hand, it is somewhat unlikely that these old versions are still in use, so we don't care too much about that.