Support building for PHP 8.4.0 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since alpha pre-releases are already available, it seems to be prudent to offer clients the ability to test their extensions for PHP 8.4 in CI.
shivammathur
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since alpha pre-releases are already available, it seems to be prudent to offer clients the ability to test their extensions for PHP 8.4 in CI.
With this patch, I've been able to build PECL/dbase for PHP 8.4. Since dbase requires no additional dependencies, this part of the code has not been checked yet, but I don't expect any issues.
Any objections to merge this? And I would like to tag
v0.9immediately after the merge, if nobody objects./cc @shivammathur