refactor: optimizing extends
and implements
#193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring and improvements to the
phper/src/classes.rs
file. The changes primarily focus on simplifying the handling ofzend_class_entry
pointers by introducing theInnerClassEntry
enum and updating related structures and methods accordingly.Key changes include:
Refactoring of
zend_class_entry
Handling:InnerClassEntry
enum to encapsulatezend_class_entry
pointers and names, replacing the previous use ofRc<RefCell<*mut zend_class_entry>>
andOption<String>
. [1] [2]StateClass
andInterface
structs to useInnerClassEntry
for managingzend_class_entry
pointers and names. [1] [2]StateClass
andInterface
to handle the newInnerClassEntry
structure, includingfrom_name
,null
,bind
, andas_class_entry
. [1] [2]Simplification of Interface Extensions:
InterfaceEntity
struct by changing theextends
field to directly storeInterface
instances instead of boxed closures.extends
method inInterfaceEntity
to pushInterface
instances directly.InterfaceEntity
to use the updatedInterface
structure for class implementations.Miscellaneous:
use
statements forptr
module inphper/src/classes.rs
.