Replace sscanf by equivalent native PHP functions because sscanf can be disabled for security reasons. #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
reviewed
Feb 2, 2020
williamdes
approved these changes
Feb 2, 2020
|
Tests seem to fail https://travis-ci.org/phpmyadmin/sql-parser/jobs/644946170#L323 |
Codecov Report
@@ Coverage Diff @@
## QA #286 +/- ##
==========================================
- Coverage 100% 99.75% -0.25%
- Complexity 1864 1865 +1
==========================================
Files 63 63
Lines 4527 4525 -2
==========================================
- Hits 4527 4514 -13
- Misses 0 11 +11 |
|
Can you run |
williamdes
approved these changes
Feb 2, 2020
devenbansod
approved these changes
Feb 3, 2020
williamdes
force-pushed
the
fix-issue-270
branch
from
7645aeb to
4b94449
Compare
…s because sscanf can be disabled for security reasons. Fixes: phpmyadmin#270
williamdes
force-pushed
the
fix-issue-270
branch
from
4b94449 to
8ea41bc
Compare
williamdes
added a commit
that referenced
this pull request
Feb 9, 2020
…e sscanf can be disabled for security reasons. Pull-request: #286 Fixes: #270 Signed-off-by: William Desportes <[email protected]>
williamdes
added a commit
that referenced
this pull request
Feb 9, 2020
Pull-request: #286 Signed-off-by: William Desportes <[email protected]>
|
Thank you @niconoe- that will reduce errors being reported to our server 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As sscanf can be disabled for security reasons, as mentioned in #270 , and also explained here: https://www.php.net/manual/en/function.sscanf.php#49713, I changed the usages by other native PHP functions, so performance should not be impacted.
Fixes: #270