Fixing conflict in lexer when '*/*' was in a query. #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## QA #287 +/- ##
=====================================
Coverage 100% 100%
- Complexity 1865 1867 +2
=====================================
Files 63 63
Lines 4526 4530 +4
=====================================
+ Hits 4526 4530 +4 |
williamdes
approved these changes
Feb 2, 2020
Sure, but what kind of tests do you want me to provide? I already tested all valid use cases of |
Maybe a new line, multiples wildcards I would like more tests on strange queries more that normal ones if possible |
|
Ok I'll provide that. Thank you for your feedback. |
|
I added more complex test cases in the provider of the lexer. Is this OK now? |
williamdes
approved these changes
Feb 2, 2020
williamdes
force-pushed
the
fix-issue-285
branch
from
992e7b1 to
101e0b0
Compare
|
CI passed ✔️ |
williamdes
added a commit
that referenced
this pull request
Feb 10, 2020
…query. Pull-request: #287 Fixes: #285 Signed-off-by: William Desportes <[email protected]>
|
Merged, thank you @niconoe- ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is willing to fix #285