Method test::getItems() with return type void returns *NEVER* but should not return anything.

[arnaud-lb]

When the doctrine plugin is enabled, I get an error with when analysing this code in level 7:

<?php

use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Collections\Selectable;

class test
{
    /**
     * @var test[]&Collection&Selectable
     */
    private $items;

    /**
     * @return test[]&Collection&Selectable
     */
    public function getItems(): Collection
    {
        return $this->items;
    }
}

The error:

Method test::getItems() with return type void returns *NEVER* but should not return anything.

[ondrejmirtes]

1) phpDoc @return test[]&Collection&Selectable definitely doesn’t make sense and gets interpreted as NeverType - you should use something like iterable<test>&Collection&Selectable, try that out. 2) I have no idea why it thinks the method has void return type. Try to fix the phpDocs and we’ll see what’s next.

On Wed, 27 Jun 2018 at 20:29, Arnaud Le Blanc ***@***.***> wrote: When the doctrine plugin is enabled, I get an error with when analysing this code in level 7: <?phpuse Doctrine\Common\Collections\Collection;use Doctrine\Common\Collections\Selectable;class test{ /** * @var test[]&Collection&Selectable */ private $items; /** * @return test[]&Collection&Selectable */ public function getItems(): Collection { return $this->items; }} The error: Method test::getItems() with return type void returns *NEVER* but should not return anything. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuMmkElDIdGLgsxR1veoQriYtHcyBks5uA870gaJpZM4U6LX0> .

-- Ondřej Mirtes

[arnaud-lb]

you should use something like iterable&Collection&Selectable

Thanks, this fixes the problem. It seems that phpstan 0.9 was handling test[] like iterable.

Also, I though it was related to this plugin, but it's not :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.