Use doctrine persistence names #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
force-pushed
the
use-doctrine-persistence-names
branch
from
56723e5 to
fc9a633
Compare
The methods `EntityManagerInterface#getReference()` and `EntityManagerInterface#getPartialReference()` have nullable return. That's properly documented for `getReference()` but had to be fixed for `getPartialReference()`.
So that things would be compatible with both ORM and ODM.
lcobucci
force-pushed
the
use-doctrine-persistence-names
branch
from
fc9a633 to
cd96d32
Compare
alcaeus
suggested changes
Aug 20, 2018
| } | ||
|
|
||
| return $type; | ||
| return TypeCombinator::addNull(new ObjectType($argType->getValue())); |
|
LGTM 😊 |
|
Merged as acada90, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to support features from both ORM and ODM.
Depends on #37