fix: update template annotations to remove covariant keyword #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses PHPStan errors related to template type variance in Doctrine's metadata classes. The errors were occurring because the template type
T
was declared as covariant but was being used in an invariant position in thegetReflectionClass()
method.The Problem
The following errors were reported by PHPStan:
Doctrine\ODM\MongoDB\Mapping\ClassMetadata::getReflectionClass()
Doctrine\ORM\Mapping\ClassMetadataInfo::getReflectionClass()
Doctrine\Persistence\Mapping\ClassMetadata::getReflectionClass()
The Solution
We removed the
-covariant
modifier from the template type declarations in:MongoClassMetadataInfo.stub
ORM/Mapping/ClassMetadata.stub
ORM/Mapping/ClassMetadataInfo.stub
Persistence/Mapping/ClassMetadata.stub
Why This Works
The covariance modifier was inappropriate in this case because:
getReflectionClass()
method returns aReflectionClass<T>
Issues
#646