Skip to content

Add sample pipeline for screen sharing using gstreamer. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fitraditya
Copy link
Contributor

Description

Add sample pipeline for screen sharing using gstreamer-send.

echo $BROWSER_SDP | gstreamer-send -video-src "ximagesrc startx=1280 show-pointer=true use-damage=0 ! video/x-raw, framerate=30/1 ! videoscale method=0 ! video/x-raw, width=1280, height=720 ! videoconvert ! queue"

@@ -51,6 +51,10 @@ These pipelines work on Linux, they may have issues on other platforms. We would

`echo $BROWSER_SDP | gstreamer-send -video-src "autovideosrc ! video/x-raw, width=320, height=240 ! videoconvert ! queue"`

* a screen, with computer generated audio.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this description matches the actual pipeline as there's no generated audio. You could say something like

live screen capture
or
live desktop capture

Copy link
Contributor

@tmatth tmatth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an updated description but otherwise lgtm

@Sean-Der Sean-Der force-pushed the example/gstreamer-send-screen-capture branch from 3f52d04 to f1e31b8 Compare October 26, 2024 02:43
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c142fba) to head (f1e31b8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #121   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          25      25           
  Lines        2803    2803           
======================================
  Misses       2803    2803           
Flag Coverage Δ
go 0.00% <ø> (ø)
wasm 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit b4164e3 into pion:master Oct 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants