Skip to content

chore(electron): various edits & refactors #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 23, 2022

Conversation

erisu
Copy link

@erisu erisu commented Dec 23, 2022

Here is various changes, let me know what you think...

Still need to complete the doc block information...

I tried to remove new Promise wrappers and replace them with async function and await but had issues.

If we can remove the new Promise wrappers, we could deindent by one.

@erisu erisu changed the title Electron3 chore(electron): various edits & refactors Dec 23, 2022
@pjoriginal
Copy link
Owner

I tried to implement async await instead of the new Promise thing too but I also had issues.
I'll see if there is a way to use async await and also the fs-sync functions to get the job done.

I just had one question. Is there a reason for the switch from arrow functions to standard function?

@pjoriginal pjoriginal merged commit 98382b6 into pjoriginal:electron3 Dec 23, 2022
@erisu erisu deleted the electron3 branch December 23, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants