Skip to content

False positives with arrow function shorthand #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrolfs opened this issue Jul 29, 2021 · 0 comments · Fixed by #23
Closed

False positives with arrow function shorthand #21

jrolfs opened this issue Jul 29, 2021 · 0 comments · Fixed by #23
Assignees

Comments

@jrolfs
Copy link

jrolfs commented Jul 29, 2021

The playwright/missing-playwright-await rule seems to be reporting false positives for expectations that are returned from brace-less arrow functions.

{
  /* ... @state/test machine ... */
  
            unchecked: {
              meta: {
                test: async ({ page }) =>
                  expect(page).toHaveText('Terms agreement is required'), // ← false positive, even though implicitly returned
              },
            },
            
  /* ... @state/test machine ... */
}

I'll try to put together a simple reproduction case.

@mskelton mskelton self-assigned this Jul 30, 2021
mskelton pushed a commit that referenced this issue Aug 5, 2021
mskelton added a commit that referenced this issue Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants