Skip to content

Add no page pause rule #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add no page pause rule #35

merged 1 commit into from
Dec 20, 2021

Conversation

mskelton
Copy link
Member

@mskelton mskelton commented Dec 19, 2021 •
edited
Loading

Fixes #34

@mskelton mskelton merged commit eeb1841 into master Dec 20, 2021
@mskelton mskelton deleted the no-page-pause branch December 20, 2021 15:26
@Nauss
Copy link

Nauss commented Dec 20, 2021

😀 Looks great ! I'll test this as soon as its available.
Thanks

klarstrup
klarstrup reviewed Dec 22, 2021
View reviewed changes
lib/index.js
@@ -46,5 +48,6 @@ module.exports = {
},
rules: {
"missing-playwright-await": missingPlaywrightAwait,
"no-page-pause": noPagePause,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to import this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just published 0.7.1

@Nauss
Copy link

Nauss commented Jan 6, 2022

Works great ! Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klarstrup klarstrup klarstrup left review comments

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error or warning on the pause calls
4 participants
@mskelton @Nauss @klarstrup @mxschmitt