Missing playwright expect rule #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
commented
Apr 28, 2021
mxschmitt
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
that's awesome! Seems to be similar to https://eslint.org/docs/rules/require-await
mxschmitt
reviewed
Apr 28, 2021
added 2 commits
April 28, 2021 16:24
|
@mxschmitt I setup the GH action, and tested it on my fork. You can see the results here: https://github.com/mskelton/eslint-plugin-jest-playwright/actions/runs/794056637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team has found that it can be easy to forget to await async playwright matchers such as
toHaveSelector, which can result in false positives since the test needs to wait for the expectation to work properly. This improves the ESLint plugin to include a new rule that will detect and auto fix this problems. For example, with this input:Auto fixed output: