-
Notifications
You must be signed in to change notification settings - Fork 42
Add new "no element handle" rule #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "no element handle" rule #40
Conversation
@mskelton when you get a chance please take a look at PR once again. I've updated it. |
Maybe we should also discourage from |
Yeah, sure. However, I'd create a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Thank you! Btw, I'd love to start working on the "page.$eval and page.$$eval" rule. What do you think is a better name for this?
|
|
Alternatively, it could be |
Adds new no-element-handle rule.
Description:
This rule disallows using the
page.$
element handle andpage.$$
element handles. Because the use of ElementHandle is discouraged, use Locator instead. Besides, it can convert an element handle to a locator.