Skip to content

Fix conditionals #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Fix conditionals #80

merged 2 commits into from
Aug 21, 2022

Conversation

mskelton
Copy link
Member

@mskelton mskelton commented Aug 20, 2022

Fixes #76

Reduces the scope of this rule to only apply to top level conditional expressions in tests.

@mskelton mskelton marked this pull request as ready for review August 20, 2022 17:40
Copy link
Collaborator

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohooo!

@mskelton mskelton merged commit 502df06 into main Aug 21, 2022
@mskelton mskelton deleted the fix-conditionals branch August 21, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-conditional-in-test conflicts with playwright's official docs
2 participants