Skip to content

fix: explicit jest plugin dependency #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2021

Conversation

chambo-e
Copy link
Contributor

@chambo-e chambo-e commented May 11, 2021

Hello 👋

I am getting a lot of errors after upgrading to 0.3.2

Definition for rule 'jest/no-standalone-expect' was not found  jest/no-standalone-expect

Because I don't have eslint-plugin-jest as an explicit plugin in my config :)

@mxschmitt
Copy link
Collaborator

This looks fine, @mskelton wdyt?

Copy link
Member

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried doing something when adding the first rule, but for some reason it wasn't working. I must have had something configured wrong as I just tested this out locally with adding jest-playwright to the recommended config and it works like a charm.

Copy link
Member

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the readme JSON trailing comma. Thanks for contributing!

Co-authored-by: Mark Skelton <[email protected]>
@mxschmitt
Copy link
Collaborator

@mskelton thanks for taking care!

@mxschmitt mxschmitt merged commit d4f39e3 into playwright-community:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants