Skip to content

Fix missing gl2d lines #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2018
Merged

Fix missing gl2d lines #2564

merged 6 commits into from
Apr 17, 2018

Conversation

dy
Copy link
Contributor

@dy dy commented Apr 16, 2018

Addresses #2397

@etpinard etpinard added bug something broken status: reviewable labels Apr 17, 2018
@etpinard
Copy link
Contributor

Thanks @dy !

Linking the two corresponding commit in regl-line2d: gl-vis/regl-line2d@ec55603, gl-vis/regl-line2d@1284107

@alexcjohnson
Copy link
Collaborator

Can you add a baseline image that would have failed before, and works now?

@etpinard
Copy link
Contributor

Yep. I'll do that now!

@alexcjohnson
Copy link
Collaborator

Thanks! LGTM 💃

- to try to avoid those:
  `ERROR: Disconnected, because no message in 30000 ms` breakage.
@etpinard
Copy link
Contributor

💃 @dy please merge this in once you published a new version of regl-line2d to npm and updated the package.json and package-lock.json files here.

@dy dy merged commit 58e8fc4 into master Apr 17, 2018
@dy dy deleted the missing-lines branch April 17, 2018 17:37
@dy dy restored the missing-lines branch April 17, 2018 18:56
@dy dy mentioned this pull request Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants