handle large circular sankey diagram #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My initial improvements were merged upstream: tomshanley/d3-sankey-circular#30 I submitted a new PR which gets rid of Once those are merged and a new npm package is published, I will link to it. Getting close! |
|
yes yes 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a shortcoming in PR #3406 which prevented it from rendering diagrams made of thousands of links with circularity.
This PR will be easier to review commit by commit.
Basically I had to improve the
identifyCircleroutine ofd3-sankey-circular. It now relies on a new npm package I made that implements Johnson's algorithm to find elementary circuits in a directed graph. This package can be found over here on Github and on npm.