Fix Axes.getAutoRange edge cases #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mboorstin Thanks very much for this PR! I won't have time to review today though. I'll do my best to review it tomorrow. 🍻 |
| newRange = minmin < 0 ? [lower, 0] : [0, upper]; | ||
| } | ||
| else if(ax.rangemode === 'nonnegative') { | ||
| newRange = [Math.max(0, lower), Math.max(0, upper)]; |
|
@mboorstin Amazing PR. Thanks very much 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: Fixes autorange issues described in #798
Details: As suggested in #798 (comment), in the first commit here I've added a bunch of unit tests for
Axes.getAutoRangeandAxes.expand, with what I think is reasonable behavior. Three of the newAxes.getAutoRangetests fail because of the behavior described in #798 (I've tagged them withTODOs in the first commit) . In the second commit I fixAxes.getAutoRangeitself, and I've also confirmed that the repro cases I gave in #798 are indeed fixed.