allow processing of sync actions resulting from state update #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending an action into the system synchronously from a ViewStore's publisher can result in state updates publishing the wrong, old, value. This PR fixes it by keeping the `Store` in `sending` state while we publish state updates. Once that's done, we check if there were any new actions coming in, in which case we feed them back and start processing again.
stephencelis
approved these changes
Sep 9, 2022
|
Thanks! Very subtle 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending an action into the system synchronously from a ViewStore's publisher can result in state updates publishing the wrong, old, value.
This PR fixes it by keeping the
Storeinsendingstate while we publish state updates. Once that's done, we check if there were any new actions coming in, in which case we feed them back and start processing again.