docs: small rephrase #1479
docs: small rephrase #1479
Conversation
| @@ -316,8 +316,7 @@ extension APIClient { | |||
|
|
|||
| Unfortunately, `XCTFail` cannot be used in non-test targets, and so this instance cannot be defined | |||
| in the same file where your dependency is registered. To work around this you can use our | |||
| [XCTestDynamicOverlay][xctest-dynamic-overlay-gh] library that dynamically invokes `XCTFail`, and | |||
| is already included in the Composable Architecture. It also comes with some | |||
| [XCTestDynamicOverlay][xctest-dynamic-overlay-gh] library that dynamically invokes `XCTFail` and is already included in the Composable Architecture. It also comes with some | |||
There was a problem hiding this comment.
It's hard to tell what's different with the newlines here. Am I correct in my reading that this PR is removing the comma between "XCTFail" and "and"? I think we're OK with the existing punctuation, but if I'm missing something please let me know!
There was a problem hiding this comment.
Hi, the second commit was to remove an accidental new line, and while I was at it I thought that removing the comma read better. Anyway, this edit is indeed negligible — this PR is mainly about removing the "automatically accessibly" which seemed like an error to me.
P. S. — I wanted to mention this in the PR's description but forgot — thank you so much for everything you do for the community and for the amazing gift that is the Composable Architecture. The ReducerProtocol release is simply mind-blowing!
There was a problem hiding this comment.
Ah, my brain didn't see that in the diff. I'm going to fix the word wrapping and then will merge!
Sources/ComposableArchitecture/Documentation.docc/Articles/DependencyManagement.md
Outdated
Show resolved
Hide resolved
…endencyManagement.md
No description provided.