Skip to content

Remove some escaping closures #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2022
Merged

Remove some escaping closures #1493

merged 6 commits into from
Oct 13, 2022

Conversation

mbrandonw
Copy link
Member

@mbrandonw mbrandonw commented Oct 13, 2022 •
edited
Loading

We have 2 unnecessary escaping closures in ForEachStore and SwitchStore. It's not actually gonna buy us anything in practice, but still they are definitely not needed.

@tgrapperon
Copy link
Contributor

Searching for content() yields a few more occurrences, like overloaded SwitchStore initializers or its Default, or IfLetStore's ElseContent. It may be worth evaluating these too.

@mbrandonw
Copy link
Member Author

@tgrapperon nice catch, I just removed a few more. thanks!

@mbrandonw mbrandonw merged commit 7b7a97f into main Oct 13, 2022
@mbrandonw mbrandonw deleted the remove-some-escaping-closures branch October 13, 2022 22:32
@tgrapperon tgrapperon mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrandonw @tgrapperon @stephencelis